reverts back in SocketAddr dedup in retransmit stage #1106
Conversation
This was erronously deemed as unnecessary and removed in: anza-xyz#864 The commit partially reverts solana-labs#864 and adds back socket-addr dedup.
behzadnouri
force-pushed
the
revert-socket-addr-dedup
branch
from
5e79777
to
b23f3d1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1106 +/- ##
=========================================
- Coverage 82.2% 82.2% -0.1%
=========================================
Files 880 880
Lines 235631 235643 +12
=========================================
+ Hits 193718 193725 +7
- Misses 41913 41918 +5 |
|
@t-nelson this is just a partial revert of the previous commit. can I get it reviewed? |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
… of anza-xyz#1106) (anza-xyz#1225) reverts back in SocketAddr dedup in retransmit stage (anza-xyz#1106) This was erronously deemed as unnecessary and removed in: anza-xyz#864 The commit partially reverts anza-xyz#864 and adds back socket-addr dedup. (cherry picked from commit fbe1dbc) Co-authored-by: behzad nouri <[email protected]>
Problem
This was erronously deemed as unnecessary and removed in: #864
Summary of Changes
The commit partially reverts #864 and adds back socket-addr dedup.